Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Yet another another attempt to fix Swift Mailer related SSL failures (Issue #4573) #13609

Closed
wants to merge 2 commits into from

Conversation

YOzaz
Copy link

@YOzaz YOzaz commented May 18, 2016

Hi, updated way of doing transport reset.

@YOzaz
Copy link
Author

YOzaz commented May 18, 2016

Right... tests need to be updated.

@taylorotwell
Copy link
Member

Mailgun transport for example has no "reset" method?

@YOzaz
Copy link
Author

YOzaz commented Jun 7, 2016

Update from my side: it's working correctly for half of the year already.

@taylorotwell
Copy link
Member

@YOzaz you're not addressing the problem. Not all drivers even have a reset method to call.

@taylorotwell taylorotwell reopened this Jun 7, 2016
@YOzaz
Copy link
Author

YOzaz commented Jun 7, 2016

@taylorotwell you're absolutely right, and I'm not complaining. Just saying that with SwiftMailer it works - therefore I had something like this implemented in my project when I was testing:

if ( ! is_a( $transport, '\Swift_Transport_AbstractSmtpTransport' ) )

... or we can even check if there's a "transport" at all.
But don't want to patch this PR further until you'll make a decision it's required. In either case, current reset (present in Laravel core) doesn't work.

@taylorotwell
Copy link
Member

You may want to check if method_exists($transport, 'reset')

@YOzaz
Copy link
Author

YOzaz commented Jun 7, 2016

@taylorotwell done: 4048a64

@YOzaz
Copy link
Author

YOzaz commented Jun 7, 2016

But still, travis is failing, and I'm not sure how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants