-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Yet another attempt to fix Swift Mailer related SSL failures (Issue #4573) #13583
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8500308
Issue #4573
schanzel 2d3c63d
Minor
schanzel 777507d
Revert return type fixes
schanzel cadbc03
Minor
schanzel e54da9a
Minor
schanzel d6c259e
- Reverted removal of Mailer::forceReconnection() method
schanzel 201749c
Minor: remove temporary result variable
schanzel 7a54388
Use private field instead of public getter for swift mailer
schanzel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -156,8 +156,6 @@ public function plain($view, array $data, $callback) | |
*/ | ||
public function send($view, array $data, $callback) | ||
{ | ||
$this->forceReconnection(); | ||
|
||
// First we need to parse the view, which could either be a string or an array | ||
// containing both an HTML and plain text versions of the view which should | ||
// be used when sending an e-mail. We will extract both of them out here. | ||
|
@@ -303,18 +301,6 @@ protected function getQueuedCallable(array $data) | |
return $data['callback']; | ||
} | ||
|
||
/** | ||
* Force the transport to re-connect. | ||
* | ||
* This will prevent errors in daemon queue situations. | ||
* | ||
* @return void | ||
*/ | ||
protected function forceReconnection() | ||
{ | ||
$this->getSwiftMailer()->getTransport()->stop(); | ||
} | ||
|
||
/** | ||
* Add the content to a given message. | ||
* | ||
|
@@ -392,7 +378,10 @@ protected function sendSwiftMessage($message) | |
} | ||
|
||
if (! $this->pretending) { | ||
return $this->swift->send($message, $this->failedRecipients); | ||
$result = $this->getSwiftMailer()->send($message, $this->failedRecipients); | ||
$this->getSwiftMailer()->getTransport()->stop(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please do a try finally here. |
||
|
||
return $result; | ||
} elseif (isset($this->logger)) { | ||
$this->logMessage($message); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't modify this line