New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Ensures MigrationCreator::create receives $create as a boolean #13439

Merged

taylorotwell merged 1 commit into laravel:5.2 from vlakoff:migration-command

May 5, 2016

Contributor

vlakoff commented May 5, 2016

Follow-up to #13409.

Previously, $create could also be:

null if no --create argument
a string if argument was --create=tablename

In both cases, MigrationCreator::create was receiving it as so, and the code was working because of loose typing.

Refs #2528, c30a4cb.


          Ensures MigrationCreator::create receives $create as a boolean

358ae65

taylorotwell merged commit 358ae65 into laravel:5.2

vlakoff deleted the migration-command branch

May 6, 2016 04:09

vlakoff mentioned this pull request

MigrateMakeCommand::writeMigration() called with erroneous $create argument #13409

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet