[5.2] change whereDate method for Postgres #12341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidavz
changed the title
|
Can you post the query that was causing problems so I can reproduce it? |
@taylorotwell Sounds like it's not a "bug", just a refactor. |
|
Here it is
|
|
Don't call |
|
It still doesn't work. |
|
? |
|
Not entirely sure. |
|
I think one problem with this is people are going to pass a full Carbon object into this and expect the time to be respected. Whereas this ::date operator is going to cut-off the hours, minutes, and seconds. |
taylorotwell
added a commit
that referenced
this pull request
Feb 26, 2016
[5.2] change whereDate method for Postgres
taylorotwell
pushed a commit
that referenced
this pull request
Mar 27, 2025
…lumns (#55159) In #12341, the cast to `::date` was added to `whereDate`. This leads to an error with PostgreSQL when passing in json column selectors. For example: `->whereDate('result->created_at', DB::raw('NOW()'))` will throw a syntax error for type date. The same is true for the `whereTime` function with its `::time` cast. To fix this, we need to wrap the column identifier in parentheses, when they are json paths. Current SQL output: ```SQL select * from "users" where "result"->>'created_at'::date = NOW() ``` Correct SQL output with this commit: ```SQL select * from "users" where ("result"->>'created_at')::date = NOW() ```
taylorotwell
pushed a commit
to illuminate/database
that referenced
this pull request
Mar 27, 2025
…lumns (#55159) In laravel/framework#12341, the cast to `::date` was added to `whereDate`. This leads to an error with PostgreSQL when passing in json column selectors. For example: `->whereDate('result->created_at', DB::raw('NOW()'))` will throw a syntax error for type date. The same is true for the `whereTime` function with its `::time` cast. To fix this, we need to wrap the column identifier in parentheses, when they are json paths. Current SQL output: ```SQL select * from "users" where "result"->>'created_at'::date = NOW() ``` Correct SQL output with this commit: ```SQL select * from "users" where ("result"->>'created_at')::date = NOW() ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had a problem with no results for a query using this method.
Wouldn't it be better to cast the column instead of the value ?