[5.2] Remove deprecated $deep param#11675
Merged
taylorotwell merged 1 commit intolaravel:5.2from Jan 4, 2016
tymondesigns:patch-1
Merged
[5.2] Remove deprecated $deep param#11675taylorotwell merged 1 commit intolaravel:5.2from tymondesigns:patch-1
taylorotwell merged 1 commit intolaravel:5.2from
tymondesigns:patch-1
Conversation
taylorotwell
added a commit
that referenced
this pull request
Jan 4, 2016
[5.2] Remove deprecated $deep param
Contributor
Author
|
Thanks Taylor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third
$deepparameter on theget()method of Symfony'sParameterBagclass has been deprecated as ofv2.8and removed completely as ofv3.0See here:
(version 2.8) - https://github.com/symfony/http-foundation/blob/2.8/ParameterBag.php#L78-L90
(version 3.0) - https://github.com/symfony/http-foundation/blob/3.0/ParameterBag.php#L88
So since laravel 5.2 requires
symfony/http-foundation2.8 or 3.0 then this needs patching right?