Replacements not working in trans_choice function

[voidgraphics]

Laravel Version

11.30.0

PHP Version

8.3.13

Database Driver & Version

Not relevant

Description

Hello!

The recent change to the trans_choice function replacements (see PR #53331) broke replacements for the count placeholder.

When using the trans_choice function and trying to specify a replacement for :count, it is no longer applied. This worked fine before the PR mentioned above was merged.

Thanks for your consideration

Steps To Reproduce

To use the same example as the PR linked above, consider the following translation:

return [
   'greeting' => '{0} Hello|[1,*] Hello, you have :count unread messages'
];

If you try to specify a replacement for :count, it will not be used, and it will simply inject the count provided as the second parameter instead. The following code:

$count = 2;

trans_choice('general.greeting', $count, ['count' => '<strong>'.$count.'</strong>']);

used to result in the following:

Hello, you have <strong>2</strong> unread messages

and now instead results in:

Hello, you have 2 unread messages

[crynobone]

In the documentation it is clear that :count is built-in placeholder to display the integer. It best to use custom placeholder such as :value as suggested in the same documentation (refer above :count)

[voidgraphics]

Ah, interesting, I suppose we missed that. It's interesting that it was not intended to work but did anyway, and it's been in production for years 😅 Do you think there's a chance that we can find a solution to avoid breaking existing apps? I'll update the translation strings if I have to, but we're looking at potentially a lot of work here. Or maybe revert the change until a major release? That way we can plan this for when we do the yearly Laravel upgrade on our projects. Thanks for your time

[crynobone]

Allowing to override :count seems a bug here based on the above documentation and reverting the #53331 will cause bug whenever trans_choice() accept a replacement string from user input containing |.

If you insist to submit a PR, feel free to make the following changes:

framework/src/Illuminate/Translation/Translator.php

Line 213 in ca0617a

$replace['count'] = $number;

-       $replace['count'] = $number;
+       $replace['count'] ??= $number;