Contextual binding does not work

[iamlucianojr]

• Laravel Version: 5.5.9
• PHP Version: 7.1.4
• Database Driver & Version: Mysql 8.0

Description:

When you use contextual binding to resolve class dependencies in controllers you got the error:

[Illuminate\Contracts\Container\BindingResolutionException]  
  Target [App\Core\Contracts\RepositoryInterface] is not in    
  stantiable while building [\App\Domains\Brands\Controller    
  s\BrandsController].

Steps To Reproduce:

• I have created a controller that depends of RepositoryInterface;

• Create the RepositoryInterface;

• Create BrandsRepository that implements the RepositoryInterface

namespace App\Domains\Brands\Controllers;
class BrandsController extends Controller
{
    public function __construct(RepositoryInterface $repository) {}
}

namespace App\Core\Contracts;
interface RepositoryInterface {}

namespace App\Domains\Brands\Repositories;
class BrandsRepository implements RepositoryInterface {}

In my service provider I have:

namespace App\Domains\Brands\Providers;

use App\Core\Contracts\RepositoryInterface;
use App\Domains\Brands\Controllers\BrandsController;
use App\Domains\Brands\Repositories\BrandsRepository;
use Illuminate\Support\ServiceProvider;

class BrandsServiceProvider extends ServiceProvider
{
     /**
     * Register the service provider.
     *
     * @return void
     */
    public function register()
    {
        $this->app->when(BrandsController::class)
            ->needs(RepositoryInterface::class)
            ->give(BrandsRepository::class);
    }
}

If I directly bind the repository it works, like this:

namespace App\Domains\Brands\Providers;

use App\Core\Contracts\RepositoryInterface;
use App\Domains\Brands\Controllers\BrandsController;
use App\Domains\Brands\Repositories\BrandsRepository;
use Illuminate\Support\ServiceProvider;

class BrandsServiceProvider extends ServiceProvider
{
     /**
     * Register the service provider.
     *
     * @return void
     */
    public function register()
    {
        $this->app->bind(RepositoryInterface::class, BrandsRepository::class);
    }
}

But of course it is not what I want, because in my others controllers domains, like customers, I will receive the BrandsRepository instead CustomersRepository for example.

[Dylan-DPC-zz]

But of course it is not what I want

Actually the 2nd way is what you need and enough for your usecase.

[iamlucianojr]

@Dylan-DPC I don't think so.

If I keep two services providers binding the same RepositoryInterface with two differents repositories the second to be loaded will receive the correct repository, but the first one will receive the same, using my use case, the BrandsController will be injected with CustomersRepository instead the BrandsRepository.

The only way to have this case correct is using contextual binding, as describe in the (Laravel documentation)

[devcircus]

I just tried the following in a fresh install and it works correctly:

// AppServiceProvider
public function register()
{
    $this->app
         ->when(UserController::class)
         ->needs(RepositoryInterface::class)
         ->give(UserRepository::class);

    $this->app
         ->when(ProfileController::class)
         ->needs(RepositoryInterface::class)
         ->give(ProfileRepository::class);
}

// routes/web.php
Route::get('/user', 'UserController@test');
Route::get('/profile', 'ProfileController@test');

[iamlucianojr]

@devcircus I did exactly the same, the fresh installation of Laravel 5.5 and it does not work for me, you can check my test here.
I really don't know I am doing wrong.

[themsaid]

I can't replicate this either.

[iamlucianojr]

@themsaid Did you use my sample project linked above to try reproduce?

[iamlucianojr]

I have tested the exactly same thing on Laravel 5.4 and 5.3. The same code works on 5.3 but doesn't on 5.4 and 5.5.

[iamlucianojr]

You guys can check here the L5.3 works well.

[devcircus]

Will clone and check out your repo. Very interested in this. If you figure it out, please follow up here.

[themsaid]

@Luciano-Jr I don't understand anything in your project, it's always better to include steps of replication clearly in the issue.

I followed the steps you put here and I couldn't regenerate the issue.

[themsaid]

How can I make this fail? It currently works and I get Yes it works when I run the TestController@index action.

[devcircus]

I cloned your project and everything works. I didn't change anything. Just added a route to hit "someMethod" in Foo controller.

Ouput when I hit that endpoint is:

"foobar"

SomeConcrete {#142}

[iamlucianojr]

I have found my error, in the routes I was declaring the route wrongly:

Route::get('foo', '\App\Http\Controllers\TestController@index');

It worked on Laravel 5.3.

If I change to the standard way it works normally:

Route::get('foo', 'TestController@index');

I guess the modification in L5.4 has caused it. The changes in the Container class has turn binding classes into the container with leading slashes no longer supported, described in Binding Classes With Leading Slashes section on documentation