Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Plurals of many languages has been missed #17816

Closed
cjmaxik opened this issue Feb 8, 2017 · 2 comments
Closed

[5.4] Plurals of many languages has been missed #17816

cjmaxik opened this issue Feb 8, 2017 · 2 comments
Assignees

Comments

@cjmaxik
Copy link

cjmaxik commented Feb 8, 2017

  • Laravel Version: 5.4.*

Description:

Since PR #15563 was introduced, Laravel has been missed a major feature for translators - plurals. While English and other langs with one|many plural scheme is working great, another languages (like Russian with more complex plural scheme) is broken right now.

Steps To Reproduce:

English locale

'apples' => ':count apple|:count apples',

1 apple | 2 apples | 24 apples | 2657 apples

Russian locale

'apples' => ':count яблоко|:count яблока|:count яблок',

Should be 1 яблоко | 2 яблока | 24 яблока | 2657 яблок
Returns 1 яблоко | 2 яблока | 24 яблока | 2657 яблока

@cjmaxik cjmaxik changed the title [5.4] Plural of many languages was missed. [5.4] Plural of many languages was missed Feb 8, 2017
@cjmaxik cjmaxik changed the title [5.4] Plural of many languages was missed [5.4] Plurals of many languages has been missed Feb 8, 2017
@themsaid themsaid self-assigned this Feb 8, 2017
@themsaid
Copy link
Member

themsaid commented Feb 8, 2017

Looking into fixing this today.

@themsaid
Copy link
Member

themsaid commented Feb 8, 2017

Here's the PR with a fix #17826

@themsaid themsaid closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants