Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageBag method has() always return true when keys is empty #14396

Closed
feralc opened this issue Jul 20, 2016 · 3 comments
Closed

MessageBag method has() always return true when keys is empty #14396

feralc opened this issue Jul 20, 2016 · 3 comments

Comments

@feralc
Copy link

feralc commented Jul 20, 2016

$errors->has() is not working anymore since commit a0cd0ae and a8df2de.
@masterdeduction
Copy link

use conditionals bruh.

crynobone added a commit to crynobone/framework that referenced this issue Jul 21, 2016
@crynobone
[5.2] Avoid introducing breaking backward compatibility on patch
b90ca2e 
release.

Closes laravel#14396

Signed-off-by: crynobone <crynobone@gmail.com>
@crynobone crynobone mentioned this issue Jul 21, 2016
Merged
@GrahamCampbell
Copy link
Member

Thanks guys.

taylorotwell pushed a commit that referenced this issue Jul 21, 2016
@crynobone @taylorotwell
[5.2] Avoid introducing breaking backward compatibility on patch rele…
2e22e71 
…ase. (#14409)

* [5.2] Avoid introducing breaking backward compatibility on patch
release.

Closes #14396

Signed-off-by: crynobone <crynobone@gmail.com>

* Add additional tests.

Signed-off-by: crynobone <crynobone@gmail.com>
@feralc
Copy link
Author

feralc commented Jul 21, 2016

You're welcome. Thanks!

@BrandonSurowiec BrandonSurowiec mentioned this issue Aug 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GrahamCampbell @feralc @masterdeduction