Skip to content

Commit

Permalink
Fix StyleCI and tests
Browse files Browse the repository at this point in the history
  • Loading branch information
fernandobandeira committed Feb 22, 2017
1 parent 8805e43 commit 707dcf1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/Illuminate/Cookie/CookieJar.php
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public function unqueue($name)
* @param string $sameSite
* @return array
*/
protected function getPathAndDomain($path, $domain, $secure = false, $sameSite)
protected function getPathAndDomain($path, $domain, $secure = false, $sameSite = null)
{
return [$path ?: $this->path, $domain ?: $this->domain, $secure ?: $this->secure, $sameSite ?: $this->sameSite];
}
Expand All @@ -172,7 +172,7 @@ protected function getPathAndDomain($path, $domain, $secure = false, $sameSite)
* @param string $sameSite
* @return $this
*/
public function setDefaultPathAndDomain($path, $domain, $secure = false, $sameSite)
public function setDefaultPathAndDomain($path, $domain, $secure = false, $sameSite = null)
{
list($this->path, $this->domain, $this->secure, $this->sameSite) = [$path, $domain, $secure, $sameSite];

Expand Down
2 changes: 1 addition & 1 deletion tests/Cookie/CookieTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function testCookiesAreCreatedWithProperOptionsUsingDefaultPathAndDomain(
$cookie = $this->getCreator();
$cookie->setDefaultPathAndDomain('/path', '/domain', true, 'lax');
$c = $cookie->make('color', 'blue');
$this->assertEquals('blue', $c->getValue());
$this->assertEquals('blue', $c->getValue());
$this->assertTrue($c->isSecure());
$this->assertEquals('/domain', $c->getDomain());
$this->assertEquals('/path', $c->getPath());
Expand Down

0 comments on commit 707dcf1

Please sign in to comment.