-
Notifications
You must be signed in to change notification settings - Fork 11.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[11.x] No need to redeclare variables (#53887)
- Loading branch information
1 parent
c17277e
commit 69284e3
Showing
1 changed file
with
11 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69284e3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasmichot - moving
$requestPort = static::getRequestPortFromLine($line);
outside the check condition creates a bug as theClosed without sending a request
does not get parsed/grouped properly by the regex ingetRequestPortFromLine()
. Since the regex does not return matches, the function then causes an exception which causes the server to fail with anInvalidArgumentException
.Example of line that will cause a problem:
[Tue Dec 17 16:25:20 2024] 127.0.0.1:59356 Closed without sending a request; it was probably just an unused speculative preconnection