Fix hostname returned when multiple host aliases are defined #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, given config: Host foo bar baz HostName 127.0.0.1 The hostname returned will return 'foo' instead of 'foo bar baz' (invalid). Fixes #230
h3xx
changed the title
|
Hold on, I found an edge case. Edit: Nevermind, I didn't introduce the edge case. Asking it for 'bar' in my example would produce null, but it did that before my change. Maybe that's by design. |
h3xx
changed the title
pgrenaud
pushed a commit
to eXolnet/envoy
that referenced
this pull request
Jul 19, 2023
…#250) For example, given config: Host foo bar baz HostName 127.0.0.1 The hostname returned will return 'foo' instead of 'foo bar baz' (invalid). Fixes laravel#230 (cherry picked from commit 8d274a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hosts with multiple aliases were returning invalid hostnames.
For example, given config:
When running
->findConfiguredHost('127.0.0.1'),'foo bar baz'was getting returned which is invalid. With this change, the hostname returned will be'foo'(valid).Also updated tests.
Fixes #230