Support client events on Pusher presence channels #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
|
Should client- automatically be prefixed to the event name? Pusher requires them to start with that prefix. |
|
Sure, done! |
|
Should we also implement this for laravel-echo-server and add it to the interface? (cc @tlaverdure ) |
|
I'm curious why this wasn't done on Private channels as well? Why only PresenceChannels? |
|
Because there is no |
|
OK I'll look into adding that when I merge this. |
|
Thanks a lot! |
|
Added support for private channel.... renamed "trigger" to "whisper"... added "listenForWhisper" to help with listening for them. Released as Echo 1.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
trigger()method onto thePusherPresenceChannelto trigger a client event.This allows the browser to send events directly to Pusher, without having to go through Laravel. It's useful for events such as a "typing..." indicator or other events where it's overkill to pass them through Laravel. In my case it's when a user starts/stops broadcasting video.
See also: #47