Skip to content

Added listen to *, stronger typing #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 5, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
{
"type": "npm",
"script": "build",
"path": "packages/react",
"path": ".",
"group": {
"kind": "build",
"isDefault": true
},
"problemMatcher": [],
"label": "npm: build - packages/react",
"label": "pnpm: build all packages",
"detail": "vite build && FORMAT=iife vite build"
}
]
Expand Down
68 changes: 52 additions & 16 deletions packages/react/src/hooks/use-echo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,36 @@ export const useEcho = <
TPayload,
TDriver extends BroadcastDriver = BroadcastDriver,
TVisibility extends Channel["visibility"] = "private",
TEvent extends string = string,
>(
channelName: string,
event: string | string[],
callback: (payload: TPayload) => void,
event: TEvent | TEvent[],
callback: (payload: TPayload, eventName: TEvent) => void,
dependencies: any[] = [],
visibility: TVisibility = "private" as TVisibility,
) => {
const callbackFunc = useCallback(callback, dependencies);
const events = toArray(event);
const callbacks = useRef<
Record<TEvent, (payload: TPayload, eventName: TEvent) => void>
>(
events.reduce(
(acc, e) => {
acc[e] = (payload: TPayload) => callback(payload, e);
return acc;
},
{} as Record<
TEvent,
(payload: TPayload, eventName: TEvent) => void
>,
),
);
const allCallbackFunc = useCallback(
(eventName: TEvent, payload: TPayload) => callback(payload, eventName),
dependencies,
);
const subscription = useRef<Connection<TDriver> | null>(null);
const listening = useRef(false);

const events = toArray(event);
const channel: Channel = {
name: channelName,
id: ["private", "presence"].includes(visibility)
Expand All @@ -104,7 +122,11 @@ export const useEcho = <
}

events.forEach((e) => {
subscription.current!.stopListening(e, callbackFunc);
if (e !== "*") {
subscription.current!.stopListening(e, callbacks.current[e]);
} else if ("stopListeningToAll" in subscription.current!) {
subscription.current.stopListeningToAll(allCallbackFunc);
}
});

listening.current = false;
Expand All @@ -116,7 +138,16 @@ export const useEcho = <
}

events.forEach((e) => {
subscription.current!.listen(e, callbackFunc);
if (e !== "*") {
subscription.current!.listen(e, callbacks.current[e]);
} else if ("listenToAll" in subscription.current!) {
subscription.current.listenToAll(allCallbackFunc);
} else {
// eslint-disable-next-line no-console
console.warn(
"listenToAll is not supported for this channel type",
);
}
});

listening.current = true;
Expand Down Expand Up @@ -171,13 +202,14 @@ export const useEcho = <
export const useEchoPresence = <
TPayload,
TDriver extends BroadcastDriver = BroadcastDriver,
TEvent extends string = string,
>(
channelName: string,
event: string | string[],
callback: (payload: TPayload) => void,
event: TEvent | TEvent[],
callback: (payload: TPayload, eventName: TEvent) => void,
dependencies: any[] = [],
) => {
return useEcho<TPayload, TDriver, "presence">(
return useEcho<TPayload, TDriver, "presence", TEvent>(
channelName,
event,
callback,
Expand All @@ -189,13 +221,14 @@ export const useEchoPresence = <
export const useEchoPublic = <
TPayload,
TDriver extends BroadcastDriver = BroadcastDriver,
TEvent extends string = string,
>(
channelName: string,
event: string | string[],
callback: (payload: TPayload) => void,
event: TEvent | TEvent[],
callback: (payload: TPayload, eventName: TEvent) => void,
dependencies: any[] = [],
) => {
return useEcho<TPayload, TDriver, "public">(
return useEcho<TPayload, TDriver, "public", TEvent>(
channelName,
event,
callback,
Expand All @@ -208,16 +241,19 @@ export const useEchoModel = <
TPayload,
TModel extends string,
TDriver extends BroadcastDriver = BroadcastDriver,
TEvent extends ModelEvents<TModel> = ModelEvents<TModel>,
>(
model: TModel,
identifier: string | number,
event: ModelEvents<TModel> | ModelEvents<TModel>[],
callback: (payload: ModelPayload<TPayload>) => void,
event: TEvent | TEvent[],
callback: (payload: ModelPayload<TPayload>, eventName: TEvent) => void,
dependencies: any[] = [],
) => {
return useEcho<ModelPayload<TPayload>, TDriver, "private">(
return useEcho<ModelPayload<TPayload>, TDriver, "private", TEvent>(
`${model}.${identifier}`,
toArray(event).map((e) => (e.startsWith(".") ? e : `.${e}`)),
toArray(event).map((e) =>
e.startsWith(".") ? e : `.${e}`,
) as TEvent[],
callback,
dependencies,
"private",
Expand Down
33 changes: 18 additions & 15 deletions packages/react/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ export type ConfigDefaults<O extends BroadcastDriver> = Record<

export type ModelPayload<T> = {
model: T;
connection: string | null;
queue: string | null;
afterCommit: boolean;
};

export type ChannelReturnType<
Expand All @@ -40,18 +43,18 @@ export type ModelName<T extends string> = T extends `${infer _}.${infer U}`
: T;

export type ModelEvents<T extends string> =
| `${ModelName<T>}Retrieved`
| `${ModelName<T>}Creating`
| `${ModelName<T>}Created`
| `${ModelName<T>}Updating`
| `${ModelName<T>}Updated`
| `${ModelName<T>}Saving`
| `${ModelName<T>}Saved`
| `${ModelName<T>}Deleting`
| `${ModelName<T>}Deleted`
| `${ModelName<T>}Trashed`
| `${ModelName<T>}ForceDeleting`
| `${ModelName<T>}ForceDeleted`
| `${ModelName<T>}Restoring`
| `${ModelName<T>}Restored`
| `${ModelName<T>}Replicating`;
| `.${ModelName<T>}Retrieved`
| `.${ModelName<T>}Creating`
| `.${ModelName<T>}Created`
| `.${ModelName<T>}Updating`
| `.${ModelName<T>}Updated`
| `.${ModelName<T>}Saving`
| `.${ModelName<T>}Saved`
| `.${ModelName<T>}Deleting`
| `.${ModelName<T>}Deleted`
| `.${ModelName<T>}Trashed`
| `.${ModelName<T>}ForceDeleting`
| `.${ModelName<T>}ForceDeleted`
| `.${ModelName<T>}Restoring`
| `.${ModelName<T>}Restored`
| `.${ModelName<T>}Replicating`;
Loading