Skip to content

fixes: unable to build #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fixes: unable to build #419

merged 1 commit into from
Apr 3, 2025

Conversation

fxnm
Copy link
Contributor

@fxnm fxnm commented Mar 27, 2025

Closes #418 by adding socket.io-client and pusher-js as peer dependencies

@taylorotwell
Copy link
Member

@SanderMuller can you take a look at this?

@taylorotwell taylorotwell marked this pull request as draft March 28, 2025 16:07
@SanderMuller
Copy link
Contributor

@SanderMuller can you take a look at this?

While adding socket.io-client and pusher-js as peerDependencies technically resolves the TS errors (especially with skipLibCheck: false), it introduces warnings for users who don’t use these drivers.

We want to avoid suggesting a Pusher user to install `socket.io-client and vice versa.

I've tried to fix this error via #420 which avoids global .d.ts exposure of these types entirely, so that TypeScript errors only occur if the corresponding driver is explicitly imported.

@SanderMuller
Copy link
Contributor

@taylorotwell I think this PR is the easiest approach to fixing the issue, however, it's not ideal (see discussion in #420). So my advise would be to either accept this PR or to accept that "skipLibCheck": false causes error in these cases.

@fxnm can you mark the PR ready for review again? Otherwise Taylor won't see these comments

@fxnm fxnm marked this pull request as ready for review April 3, 2025 13:33
@taylorotwell taylorotwell merged commit 2a87a80 into laravel:2.x Apr 3, 2025
3 of 4 checks passed
@fxnm fxnm deleted the patch-1 branch April 3, 2025 14:44
@fxnm
Copy link
Contributor Author

fxnm commented Apr 10, 2025

@taylorotwell could you create a release?
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete Bug Fix of "Unable to build application due to missing type declarations. #415"
3 participants