New Helper elementScreenshot
#1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding on the existing helpers for
screenshotandresponsiveScreenshotsthis new helper is for taking a screenshot of a specific element, by passing in the$selectorfor the element and then using thetakeElementScreenshot()method of theRemoteWebElement::class.As the element needs to be 'in view' before the screenshot can be taken, the helper first calls
scrollIntoViewbefore taking the screenshot.Of course, the same could be achieved by adding a
Browser::macroin the service provider, but this pull request would put it alongside the existing methods and include in the package.Tests have been included that follow a similar pattern as those for the
screenshotmethod.