Skip to content

Conversation

alexanderkroneis
Copy link

This PR adds a low level documentation of guest checkout which will be released in a few in laravel/cashier-stripe.

@taylorotwell
Copy link
Member

taylorotwell commented Sep 27, 2022

I find these docs a bit sparse. What are $items? Can we show an actual example? What might the application do after a guest completes the checkout?

@taylorotwell taylorotwell marked this pull request as draft September 27, 2022 17:50
@alexanderkroneis
Copy link
Author

I‘ll provide some further details, thank you for your improving commit. 👏

@alexanderkroneis alexanderkroneis changed the title add guest checkout docs [9.x] add guest checkout docs Sep 29, 2022
@alexanderkroneis
Copy link
Author

I improved the documentation a little more, still not perfect imho.

@driesvints
Copy link
Member

@alexgaal can you remove the .idea folder?

See https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

@alexanderkroneis
Copy link
Author

@alexgaal can you remove the .idea folder?

See https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

Thank you for that tip, I just added .idea to my global gitignore. 🎉

@driesvints driesvints marked this pull request as ready for review September 30, 2022 09:24
@driesvints
Copy link
Member

I tried to improve this even further by referencing the checkout.session.completed at the end and how to fulfill orders. @taylorotwell I don't think we need to explain $items as we don't do that anywhere in the other checkout docs. It should be pretty obvious that you can pass prices.

@taylorotwell taylorotwell merged commit 95b1d49 into laravel:9.x Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants