Skip to content

[9.x] Symfony Mailer breaking changes #7629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

deleugpn
Copy link
Contributor

@deleugpn deleugpn commented Jan 26, 2022

This is another part of laravel/framework#40649 changing the documentation on how to work with AWS SES.

@deleugpn deleugpn changed the title Symfony Mailer breaking changes [9.x] Symfony Mailer breaking changes Jan 26, 2022
@taylorotwell
Copy link
Member

taylorotwell commented Jan 27, 2022

We need to address this at the framework level. Seems kinda unacceptable from a DX perspective to require this on every mailable you send?

@driesvints

@driesvints
Copy link
Member

I'll be working on a PR tomorrow for symfony/amazon-mailer so that originally functionality can be restored.

@deleugpn
Copy link
Contributor Author

It's not as bad as it looks when you wrap the Mailer class with a decorator that knows that will be using SES and can apply the appropriate tag unconditionally.

The lack of tag support on Amazon Mailer for SES is kind of a bummer, but to be honest I actually liked how I managed to replace 5 Mailer config with just 1 + dedicated methods on my decorator to define the configuration set.

@taylorotwell
Copy link
Member

@driesvints @deleugpn can this be closed in light of laravel/framework#40696 ?

@deleugpn
Copy link
Contributor Author

I will look into the Framework Pull Requests tomorrow or Monday and will report back. In the meantime, I will already go ahead and close this one. Thanks, everyone!

@deleugpn deleugpn closed this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants