Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix duplicated ids when rendering, missing style definitions #7502

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[8.x] Fix duplicated ids when rendering, missing style definitions #7502

merged 1 commit into from
Dec 13, 2021

Conversation

driade
Copy link
Contributor

@driade driade commented Dec 12, 2021

This pull requests tries to fix some errors found when rendering the docs with Parsedown.

<h4 id="method-all" id="collection-method" class="first-collection-method"><code>all()</code></h4>

which causes and invalid html. It's not a very big issue unless you're trying to make an epub out it (please see the screenshot)

  • Second, trying to follow the idea behind collections.md, where the methods have a class to make the "code" tag render with 14px, and having the first element also the class ".first-collection-method", I've checked a few files where the css style was missing or the class was not correctly added to the code.

If accepted this pull requests should be backported.

Thanks.

Captura de pantalla 2021-12-12 a las 12 24 22

@driade driade changed the title fix duplicated ids when rendering, missing style definitions [8.x] fix duplicated ids when rendering, missing style definitions Dec 12, 2021
@driade driade changed the title [8.x] fix duplicated ids when rendering, missing style definitions [8.x] Fix duplicated ids when rendering, missing style definitions Dec 12, 2021
@taylorotwell taylorotwell merged commit 0114efa into laravel:8.x Dec 13, 2021
ongyjho added a commit to ongyjho/docs that referenced this pull request Feb 1, 2022
- ID attr 중복 렌더링 문제로 인한 style sheet 변경 (laravel/docs#7502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants