[8.x] fortify.md #6979
Merged
[8.x] fortify.md #6979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a small documentation inconsistencies for declaring views. Some code examples are in php 7.4 syntax instead of 7.3. And, having in mind, that Laravel 8 minimum requirement is php 7.3, then syntax from php 7.4 (new features) are not correct in this context. Code examples that are NOT OK (7.4 syntax used - closure), are for: - Login (https://laravel.com/docs/8.x/fortify#authentication) - Registration (https://laravel.com/docs/8.x/fortify#registration) - Email Verification (https://laravel.com/docs/8.x/fortify#email-verification) Code examples that are OK (7.3 syntax), are for: - Requesting A Password Reset Link (https://laravel.com/docs/8.x/fortify#requesting-a-password-reset-link) - Resetting The Password (https://laravel.com/docs/8.x/fortify#resetting-the-password) - ... I did not check the whole documentation, so please do that in the context of php syntax (to be valid with php 7.3). Thank you, and best wishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a small documentation inconsistencies for declaring views. Some code examples are in php 7.4 syntax instead of 7.3.
And, having in mind, that Laravel 8 minimum requirement is php 7.3, then syntax from php 7.4 (new features) are not correct in this context.
Code examples that are NOT OK (7.4 syntax used - closure), are for:
Code examples that are OK (7.3 syntax), are for:
I did not check the whole documentation, so please do that in the context of php syntax (to be valid with php 7.3).
Thank you, and best wishes.