[8.x] Update the docs to reflect the merge of reduceWithKeys into the existing reduce method #6743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mokhosh
commented
Jan 14, 2021
| @@ -1725,7 +1721,7 @@ The `reduceWithKeys` method reduces an associative collection to a single value, | |||
|
|
|||
| $collection->reduceWithKeys(function ($carry, $value, $key) use ($ratio) { | |||
| return $carry + ($value * $ratio[$key]); | |||
| }, 0); | |||
| }); | |||
There was a problem hiding this comment.
I previously added 0 as $initialValue to the example to make it clear that reduceWithKeys also accepts initial value. But now that it's merged into reduce and we already show that in the previous example there is no need for that and we can remove it to simplify and make it more readable.
|
I got confused by this one, should this one not be something like this? "The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Collection docs to reflect latest changes in
reduceAs discussed here: laravel/framework#35839
The new pull request to framework here: laravel/framework#35878
Previous change to the docs that was merged and needs to be updated because the underlying changed was reverted here: #6740