Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Update service provider code examples #5163

Merged
merged 1 commit into from
Apr 29, 2019
Merged

[5.8] Update service provider code examples #5163

merged 1 commit into from
Apr 29, 2019

Conversation

SjorsO
Copy link
Contributor

@SjorsO SjorsO commented Apr 29, 2019

The order of the register and boot method was changed in laravel/laravel#4921. The docs weren't updated, which caused this problem: #5158.

This PR updates the order of the register and boot methods for all code examples in the docs. It also updates the docblock text to match the text currently used by the framework.

@taylorotwell taylorotwell merged commit 66f84c3 into laravel:5.8 Apr 29, 2019
m777z pushed a commit to m777z/laravel-docs that referenced this pull request Jun 8, 2019
m777z added a commit to m777z/laravel-docs that referenced this pull request Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants