Skip to content

[5.4] Misc improvements to collections documentation #3228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2017
Merged

[5.4] Misc improvements to collections documentation #3228

merged 1 commit into from
Mar 26, 2017

Conversation

paulofreitas
Copy link
Contributor

I did a thorough review of collections's documentation and ended up with a few minor corrections and additions:

  • Added missing average() alias method (synced Eloquent collections documentation)
  • Added missing containsStrict() anchor (sorry to have forgotten this!)
  • Added missing cross-reference links to contains(), containsStrict(), slice(), unique() and uniqueStrict() methods
  • Added missing explanations about "loose" comparisons to where(), whereIn() and whereNotIn() methods
  • Minor change to merge() method to state that it also accepts another collections
  • Minor change to toJson() method to better describe the returned value
  • Minor formatting fixes, mostly on code snippets

Just to make Laravel's documentation even more awesome. ❤️

@paulofreitas paulofreitas changed the title [5.4] Improvements to collections documentation [5.4] Misc improvements to collections documentation Mar 26, 2017
@taylorotwell taylorotwell merged commit 7dcca4c into laravel:5.4 Mar 26, 2017
@taylorotwell
Copy link
Member

Thanks 👍

@paulofreitas paulofreitas deleted the collections-improvements branch March 26, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants