Override plural by the range #3099
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since laravel/framework#17826 bring back the plurals, I find that Symfony's construction like `{0} There are none|There are one|There are many` is no longer work. However, it works in opposite direction now (like in PR). Since there is no mention how user can do that later, we can add this now. Also it should works in other languages (like Russian) with more complex plural: `'comments_count' => ':count комментарий|:count комментария|:count комментариев|{0} Нет комментариев',` 0 => Нет комментариев 1 => 1 комментарий 2 => 2 комментария 5 => 5 комментариев
|
I don't know what this means. |
|
This is already demonstrated right above your example. |
|
This is not the same. Example right above will not use internal plural (https://github.com/laravel/framework/pull/17826/files/b2d997dcfb73347670e6261f6d6cae3980aa9181#diff-4b78d7d05e662d3ea18c7e872456ec96R111) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since laravel/framework#17826 bring back the plurals, I find that Symfony's construction like
{0} There are none|There are one|There are manyis no longer work. However, it works in opposite direction now (like in PR). Since there is no mention how user can do that later, we can add this now.Also it should works in other languages (like Russian) with more complex plural:
'comments_count' => ':count комментарий|:count комментария|:count комментариев|{0} Нет комментариев',0 => Нет комментариев
1 => 1 комментарий
2 => 2 комментария
5 => 5 комментариев