Skip to content

[5.0] Completed Coverage to 2 traits #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2019

Conversation

ericktucto
Copy link
Contributor

I added unit test for the trait InteractsWithExceptionHandling, InteractsWithSession (completed coverage)

On branch test-session-exception
Changes to be committed:
new file: tests/Stubs/ExceptionHandlerStub.php
new file: tests/Stubs/OutputStub.php
new file: tests/Unit/InteractsWithExceptionHandlingTest.php
modified: tests/Unit/InteractsWithSessionTest.php

On branch test-session-exception
Changes to be committed:
    new file:   tests/Stubs/ExceptionHandlerStub.php
    new file:   tests/Stubs/OutputStub.php
    new file:   tests/Unit/InteractsWithExceptionHandlingTest.php
    modified:   tests/Unit/InteractsWithSessionTest.php
@ericktucto ericktucto closed this Mar 2, 2019
@ericktucto ericktucto deleted the test-session-exception branch March 2, 2019 00:30
@ericktucto ericktucto restored the test-session-exception branch March 2, 2019 00:35
On branch test-session-exception
Changes to be committed:
    modified:   src/Concerns/InteractsWithExceptionHandling.php
    modified:   tests/Stubs/ExceptionHandlerStub.php
    modified:   tests/Unit/InteractsWithSessionTest.php
@ericktucto
Copy link
Contributor Author

ericktucto commented Mar 2, 2019

@driesvints @taylorotwell Illuminate\Contracts\Debug\ExceptionHandler have 1 method and must be declared on browser-kit-testing/src/Concerns/InteractsWithExceptionHandling.php

I send the solution on ericktucto/browser-kit-testing@05470f8

https://github.com/laravel/framework/blob/00624592ef044c2ddae5cbc324d39928f5b4bb70/src/Illuminate/Contracts/Debug/ExceptionHandler.php#L23

@ericktucto ericktucto reopened this Mar 2, 2019
@taylorotwell taylorotwell merged commit bfb016e into laravel:5.0 Mar 3, 2019
@ericktucto ericktucto deleted the test-session-exception branch March 5, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants