Change default value for browser_logs_watcher #308
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add better default value. We typically don't want to inject the watcher on production sites.
|
Thanks for your pull request to Boost! Unfortunately, I’m going to delay merging this code for now. It’s already configured in the same way, and browser logger isn’t registered if app debug is false. boost/src/BoostServiceProvider.php Line 186 in 707c749 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add better default value for browser_logs_watcher.
We typically don't want to inject the watcher on production sites. This way, we disable the watcher by default when the application doesn't have debugging enabled.