American Express 4-digit CVV #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkaOnLine
reviewed
Jul 28, 2021
| * @var array | ||
| */ | ||
| protected $cvc_length = [3, 4]; | ||
| protected $cvc_length = [4]; |
There was a problem hiding this comment.
But American Express supports 3 and 4 digits:
https://www.americanexpress.com/ca/en/articles/life-with-amex/learn/what-is-credit-card-cvv/
This three- or four-digit code tells the merchant that you are in possession of the card
There was a problem hiding this comment.
I think it's referring to a CVV code in general, since in the previous paragraph it says:
Depending on your credit card provider [...]
But later, they explicitly say (the part I quoted in the PR):
If you have an American Express® Card, you will find the four-digit credit card CVV [...]
ssx
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
American Express cards only support 4-digit security codes.
Source: https://www.americanexpress.com/ca/en/articles/life-with-amex/learn/what-is-credit-card-cvv/
This PR makes the AmericanExpress cards explicitly have 4-digit CVC and adds 2 test assertions.