Skip to content

Fix timeout parameter #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2025

Conversation

ryangittings
Copy link
Contributor

Potential fix for #158

Copy link

@throcha3 throcha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2.3 of berkayk packaged changed the signature of the client coonstructor then we reversed the ordering change for v2.4
This should solve the problem. Thanks for the commit

@throcha3
Copy link

throcha3 commented Feb 7, 2025

@LKaemmerling can you help us here, please?

Copy link

@mhuryanov mhuryanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@throcha3
Copy link

@atymic @Lloople could anyone help here, please?

@zupaazhai
Copy link

we need someone to merge this 👍

@mhdcodes
Copy link

👍

@atymic atymic merged commit 7c9bdbe into laravel-notification-channels:master Feb 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants