Skip to content

Added a new components param #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2023

Conversation

romulosalmeida
Copy link
Contributor

@romulosalmeida romulosalmeida commented Jan 29, 2023

Hi guys,

This PR will allow us to pass the components argument to the DiscordMessage::create method.

Discord reference: https://discord.com/developers/docs/resources/channel#create-message-jsonform-params

Result:

image

image

@freekmurze
Copy link
Member

Could you rebase this against the current master, that should make the tests pass.

@romulosalmeida
Copy link
Contributor Author

romulosalmeida commented Feb 1, 2023

Thank you!

Tests are passing now.

@lukas-frey
Copy link

Awesome, just what I'm looking for! Any info on when this will be released? :-)

@romulosalmeida
Copy link
Contributor Author

@freekmurze is there anything else to be done?

Thanks.

@romulosalmeida
Copy link
Contributor Author

@freekmurze, could you analyse this PR, please?
Thanks.

@atymic atymic merged commit a4ef4fc into laravel-notification-channels:master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants