Added hasManyThrough relationship type.

[dalabarge]

Added hasManyThrough relationship type from Laravel 4.1. Made all named indexes consistent with Laravel 4.1 on Ardent relationship definitions. Revised documentation to be more readible when it comes to relationship key requirements.

[igorsantos07]

desc r iption xD

[igorsantos07]

Man, this looks great (: Thanks for the PR, first for the new feature and second for fixing my English mistakes. I'm not native and sometimes I make mistakes. hahaha

However, before merging I would ask you two things:

• As commented above, there's a tiny typo in your updates
• Take a look at the "Files changed" tab and you'll notice there's a difference between your spacing and ours. I think we're using tabs and you're using spaces, and that makes some lines you changed unaligned with the current codebase. Would you mind fixing that as well?

I promise you I'll merge the PR as soon as those points are fixed! You won't wait another month for it :P

[dalabarge]

@igorsantos07 thanks for pointing that all out. I think I fixed it according to your guidelines. Let me know if there is anything else. Also I'd be happy to helps with the package maintenance including moderating some PRs and issues if that helps reduce the delays. I used this package alot so I'd be happy to help give back with some management of it all.

[dalabarge]

@igorsantos07 what's the word on merging this?

[igorsantos07]

Time, time, time! Here I am (:

[igorsantos07]

Space still looks strange, although I can't understand it correctly from my phone. I'll try to see that in the computer soon!

[igorsantos07]

Ok, I got it now. The file itself had troublesome spacing, and you fixed that. However, GitHub does not have the option to ignore whitespace in the diff, so I'm diff'ing in the command-line now.

I noticed that you've added the relation arguments: localKey, otherKey, pivotKey, timestamps.
Have you tested all those?

• There's a typo on those changes that would make the pivotKey not work;
• Additionally, I think those new arguments should be used in their respective call (lines with return $this->$relationType()). Take care to not override current behaviour, or turn what's optional now into required.

I've merged this master into your master and the result is in a new temporary branch called bexarcreativeinc-master. I did that to safely compare your work against the current master in the command-line, with the option -w and thus see exactly your code changes and only those. If you do new changes to your branch (the one from this PR), try to rebase/merge it first with master as well (:

[dalabarge]

I'll need a bit of time to finish this up. If you have all of this source in bexarcreativeinc-master then I'll fork that and publish a new pull request so you can safely close this one then. It looks like you've already pushed out code that fixes the Laravel incompatibility so at this point it's a matter of adding the hasManyThrough() features. I'll start again with the new PR as soon as I get a chance.