Skip to content

Add unit tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2017
Merged

Add unit tests #2

merged 4 commits into from
Nov 22, 2017

Conversation

SergeyPodgornyy
Copy link
Member

@SergeyPodgornyy SergeyPodgornyy commented Nov 21, 2017 •
edited
Loading

Description

Add unit tests

Motivation and context

100% test coverage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

(http://www.phptherightway.com/#continuous-integration) server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@SergeyPodgornyy SergeyPodgornyy merged commit 601ee3f into master Nov 22, 2017
@SergeyPodgornyy SergeyPodgornyy deleted the feature/tests branch November 22, 2017 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SergeyPodgornyy