Skip to content

use laravel contract instead of dispatcher class #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

mcharytoniuk
Copy link
Contributor

it is possible to use this panel with OctoberCMS that is based on Laravel, but it uses custom EventDispatcher: https://github.com/octobercms/library/blob/master/src/Events/Dispatcher.php ; it follows dispatcher contract though -in general using contract is more generic solution

it is possible to use this panel with OctoberCMS that is based on Laravel, but it uses custom EventDispatcher: https://github.com/octobercms/library/blob/master/src/Events/Dispatcher.php ; it follows dispatcher contract though -in general using contract is more generic solution
@marktopper
Copy link
Member

marktopper commented Feb 8, 2018

Thanks 👍
If you don't, then I might look into making support for OctoberCMS someday.

@marktopper marktopper merged commit 60ef817 into larapack:master Feb 8, 2018
@mcharytoniuk mcharytoniuk deleted the patch-1 branch February 8, 2018 11:12
@mcharytoniuk
Copy link
Contributor Author

@marktopper yeah, I might. It would be useful to have a panel independent from OctoberCMS one, because OctoberCMS's backend is not accessible by registered users and not really customizable. Having something like Voyager available would be a great improvement. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants