Load shell environment when launching from GUI #1461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lapce attempts to launch sub-processes (i.e. a LSP) that depend on environment variables like a customized
PATH
it will fail as long as it has been launched from the GUI (at least on macOS).This is due to the fact that i.e. macOS does not load the user's shell environment when launching an app. This can be mitigated by starting a login shell and extracting all environment variables from it. A strategy described in this comment on the Atom Editor project.
I have tested this on macOS, and it resolved all issues of lapce not being able to find LSP executables like
pylsp
. For Linux, I do not know if it is actually necessary or if the correct environment is available to lapce there.