Load shell environment when launching from GUI

[TitanNano]

When lapce attempts to launch sub-processes (i.e. a LSP) that depend on environment variables like a customized PATH it will fail as long as it has been launched from the GUI (at least on macOS).

This is due to the fact that i.e. macOS does not load the user's shell environment when launching an app. This can be mitigated by starting a login shell and extracting all environment variables from it. A strategy described in this comment on the Atom Editor project.

I have tested this on macOS, and it resolved all issues of lapce not being able to find LSP executables like pylsp. For Linux, I do not know if it is actually necessary or if the correct environment is available to lapce there.

[panekj]

I'm against this type of workaround

[TitanNano]

@panekj
a. What do you not like about it?
b. what would you suggest as an alternative solution?

[panekj]

a) the fact that it's messing with environment
b) not doing it at all, plugins should correct their behaviour

[TitanNano]

a) the fact that it's messing with environment

Fair point. What about setting env variables on the Command when launching the subprocess?

b) not doing it at all, plugins should correct their behaviour

I don't see how plugins can resolve this issue. Even when a plugin accepts a serverPath to, i.e. /opt/homebrew/bin/pylsp the LSP will then not be able to locate the python interpreter, as it has also been installed via Homebrew and is not in the macOS standard PATH.

Lapce not having access to Homebrew installed executables is a high inconvenience for users on macOS.

[codecov-commenter]

Codecov Report

Merging #1461 (155df0e) into master (7c993f9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #1461      +/-   ##
=========================================
- Coverage    6.10%   6.09%   -0.01%     
=========================================
  Files         123     123              
  Lines       49822   49853      +31     
=========================================
  Hits         3041    3041              
- Misses      46781   46812      +31     

Impacted Files	Coverage Δ
lapce-ui/src/app.rs	0.00% <0.00%> (ø)
lapce-data/src/data.rs	0.00% <0.00%> (ø)
lapce-ui/src/editor/tab_header_content.rs	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more