-
Notifications
You must be signed in to change notification settings - Fork 189
DesignSystem improvements
#972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
14fd7e8 to
bd98422
Compare
|
Bumped to 1.90 as |
9b2c2c1 to
7929c78
Compare
|
Hmm. I thought that this would improve the performance of the style pass but it doesn't actually seem to make a difference. What was the motivation for this change? There is a regression on disabled text color |
Styles in most places accept a |
|
The motivation was to make it do more work at compile time instead of runtime, but if its not making a difference then yeah, feel free to close it. |
|
I think all of the clippy if let chains would be good to merge. Maybe let's just revert the changes to theme.rs |
|
Will do that. However, will keep |
000d706 to
6d75f91
Compare
6d75f91 to
12e96ed
Compare
|
@jrmoulton PR is ready for review. |

This PR is making an effort to improve upon existing
DesignSystem.hslhelper function