create index on empty table #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngalstyan4
reviewed
Aug 9, 2023
test/sql/hnsw_insert_empty_table.sql
Outdated
|
|
||
| CREATE TABLE small_world ( | ||
| id varchar(3), | ||
| vector vector(3) |
There was a problem hiding this comment.
Can you make this test with arrays and drop vector dependency?
And, use the small_world definition from test_helpers (just \ir test_helpers/small_world_arrays.sql)
src/hnsw/external_index.c
Outdated
| @@ -1,4 +1,3 @@ | |||
|
|
|||
| #include "postgres.h" | |||
There was a problem hiding this comment.
Use <...> for postgres headers (#include "postgres.h")
davkhech
force-pushed
the
feature/create-index-on-empty-table
branch
from
b844bb3
to
6e89143
Compare
|
Merged these changes through your newer PR (#41). Thanks for your contribution! |
var77
added a commit
that referenced
this pull request
Oct 8, 2024
* - Create lock table in lantern schema - Hash client trigger function and trigger names so they won't exceed the character limit * Bump cli version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when index is crated on empty table there is only header block
when new data is added, we add block map and data pages and populate them