pg17 support #348
Merged
pg17 support #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage
7 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
…led from post_parse_analyze hook was causing an error `ERROR: ResourceOwnerEnlarge called after release started`. This was coming from the function call `LookupOperName` which uses `SearchCatCacheList` (src/backend/utils/cache/catcache.c:1754) to search in catalog and ifa match is found it will call `ResourceOwnerEnlarge` to grow the hash if needed. This error seems to happen when the transaction is reverted because of an error and the list needs to grow. We will now keep the found operator oids in `CacheMemoryContext` and search them again only if it does not exist. We will not free the list and let it go after the `CacheMemoryContext` will be reset
var77
force-pushed
the
varik/pg17-support
branch
from
98e5a09
to
1a7fee8
Compare
Benchmarks
|
var77
force-pushed
the
varik/pg17-support
branch
from
e3bd0f9
to
f2fec11
Compare
…ion. After release of Postgres 17, search_path is restricted to (pg_catalog, pg_temp) for maintenance operations [ref: postgres/postgres@2af07e2] So when pgvector was installed in public schema and we will try to get the oid for vector type using `TypenameGetTypid("vector")` it would return `InvalidOid` By this change the function `TypenameGetVectorTypid` will call SQL function `get_vector_type_oid` which will query pg_type table and return the vector type oid
in `InitBuildState` we would try to close that file descriptor (which would be 0) in `BuildIndexCleanup` function because of condition `if (buildstate->index_file_fd != -1)` and trying to close fd 0 was crashing the server. Now we will check if the fd is greater than 0 before closing it.
…xtension when invalid binary would be installed
var77
force-pushed
the
varik/pg17-support
branch
6 times, most recently
from
b65017e
to
702a254
Compare
if enable_seqscan is set to false. Modify failing tests because of operator rewrite hook to not use <?> operator. Modify test output files accordingly.
var77
force-pushed
the
varik/pg17-support
branch
from
702a254
to
18f83e1
Compare
…rStart_hook` hooks and related codes. Update tests to not use <?> operator
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Ngalstyan4
approved these changes
Nov 1, 2024
| @@ -49,7 +49,8 @@ def __repr__(self): | |||
| return self.version | |||
|
|
|||
| INCOMPATIBLE_VERSIONS = { | |||
| '16': [Version('0.0.4')] | |||
| '16': [Version('0.0.4')], | |||
| '17': [Version('0.3.0'), Version('0.3.1'), Version('0.3.2'), Version('0.3.3'), Version('0.3.4'), Version('0.4.0'), Version('0.4.1')], | |||
There was a problem hiding this comment.
If we no longer have servers at an older 0.3.* version that we need to upgrade from, you can also move old update scripts to old_updates
There was a problem hiding this comment.
there are still servers with 0.3.x versions, will move the update files to old_updates once all servers are upgraded
| id | ||
| ---- | ||
| 1 | ||
| 2 | ||
| 3 | ||
| (3 rows) | ||
|
|
||
| DROP INDEX cos_idx; | ||
| CREATE INDEX ham_idx ON small_world_arr USING lantern_hnsw(v) WITH (m=3); |
There was a problem hiding this comment.
was this supposed to be testing hamming distance? it seems the index creation uses the default l2sq operator in this case as well - there is a typo in the old test.
There was a problem hiding this comment.
fixed to create an index with correct opclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.