resource: moved managed field into ResourceGroup#38
Open
resource: moved managed field into ResourceGroup#38
Conversation
Also changes management loop to respect new managed flag.
bertschinger
requested changes
Feb 5, 2026
| *res.managed.lock().unwrap() = payload.managed; | ||
| for rg in cluster.resource_groups() { | ||
| if rg.root.id == resource_id { | ||
| *rg.managed.lock().unwrap() = payload.managed; |
Collaborator
There was a problem hiding this comment.
This should be updated to use the set_managed() method rather than directly accessing the field.
| // single object that can carry data (i.e., an Enum that says the reason for the notification) | ||
| pub switch_host: tokio::sync::Notify, | ||
|
|
||
| pub managed: Mutex<bool>, |
Collaborator
There was a problem hiding this comment.
This field should be made private so that the public interface is constrained to the set_managed() and get_managed() methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also changes management loop to respect new managed flag.