-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contact 3 of 3 #202
Open
gabemorris12
wants to merge
40
commits into
lanl:main
Choose a base branch
from
gabemorris12:contact3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Contact 3 of 3 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yaml input now accepts 'global' as a geometry option for the boundary conditions. This is for contact only and means that contact will be checked on all boundary patches. Additionally, there is some cleanup here as contact features will begin to be added.
Setting things up with a function pointer for the case where there is no contact, an empty function will be getting executed instead of hitting an if statement.
Additionally, the contact_test.geo was changed so that the patch ordered in outward normal. Added additional members to contact_patch_t and contact_patches_t. Getting everything set up for the bucket sorting.
All the previous sorting methods lead up to the ability to find nodes that could potentially penetrate a patch. This ability is now implemented with the contact_patches_t::find_nodes function.
Added the get_contact_point method which determines the reference coordinates of the intersection point.
…t_nodes; added unit test for get_contact_point
… del_tc instead to prevent matar array allocation
… added the corresponding unit test
Additionally, I've done a restructure of the unit test so that it can be based on the file name.
Refer to edge_cases.py
All tests are working and results are identical to the python implementation.
… from the sort() method
…efore the analysis The reason why it's important to call before is so that the internal force gets updated.
…emented in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the third and final stage of the implementation of the contact algorithm, which adds force resolution. The results look great.
sie_test.mp4
slide_test.mp4
mult_hit.mp4
As a future note, a multi-stage detection process is not yet implemented. Without this, expect to see some issues with a node sliding across a concave surface and also with three or more bodies resting on each other. Additionally, an error study should be conducted too.
Type of change
Please select all relevant options
How Has This Been Tested?
sgh_solver.h
and comment out therun_contact_tests
function. The input file should be contact_test.yaml. This will perform the previously implemented tests as well as the additional force resolution test.contact_sie_test.yaml
,multi_hit_test.yaml
, andblock_sliding_test.yaml
to see that they match with the above results.Test Configuration:
Checklist: