-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JuMP v1.15 nonlinear syntax #155
Conversation
Only substantive change is from a registered function for the head loss to something that is now traceable.
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 92.04% 91.99% -0.05%
==========================================
Files 39 39
Lines 4198 4174 -24
==========================================
- Hits 3864 3840 -24
Misses 334 334
Continue to review full report in Codecov by Sentry.
|
I don't understand the 1.6 failure. That just seems wrong. Statistics is a stdlib... |
@ccoffrin this is ready to go on my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks, @odow! Super excited by the new nonlinear interface.
LGTM. Before tagging the next release we should also make sure to fix #156 (which is many be covered in this PR as well) |
I just realized one potential issue: do you have projects that integrate PowerModels and WaterModels? If so, if one use the |
We do have some packages that combine the infrastructure models packages. These are the ones I can think of off the top of my head, As long long as the version of each package that updates to the new NL interface is a breaking release then the package version requirements should prevent incompatible versions. However, I do think we should put a concerted effort into updating the whole ecosystem to the new NL interface, so the packages can still interoperate as they progress. |
Only substantive change is from a registered function for the head loss to something that is now traceable.
x-ref lanl-ansi/PowerModels.jl#858
Closes #61
Closes #156