Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JuMP v1.15 nonlinear syntax #155

Merged
merged 7 commits into from
Sep 17, 2023
Merged

Conversation

odow
Copy link
Collaborator

@odow odow commented Apr 25, 2023

Only substantive change is from a registered function for the head loss to something that is now traceable.

x-ref lanl-ansi/PowerModels.jl#858

Closes #61
Closes #156

Only substantive change is from a registered function for the head
loss to something that is now traceable.
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #155 (873e174) into master (df331a2) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   92.04%   91.99%   -0.05%     
==========================================
  Files          39       39              
  Lines        4198     4174      -24     
==========================================
- Hits         3864     3840      -24     
  Misses        334      334              
Files Changed Coverage Δ
src/prob/wf.jl 100.00% <ø> (ø)
src/core/function.jl 100.00% <100.00%> (ø)
src/form/crd.jl 100.00% <100.00%> (ø)
src/form/nc.jl 99.26% <100.00%> (ø)
src/form/ncd.jl 95.52% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df331a2...873e174. Read the comment docs.

src/form/crd.jl Show resolved Hide resolved
test/common.jl Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@odow
Copy link
Collaborator Author

odow commented Sep 1, 2023

I don't understand the 1.6 failure. That just seems wrong. Statistics is a stdlib...

@odow odow closed this Sep 1, 2023
@odow odow reopened this Sep 1, 2023
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@odow odow changed the title WIP: update to new JuMP nonlinear syntax Update to JuMP v1.15 nonlinear syntax Sep 15, 2023
@odow
Copy link
Collaborator Author

odow commented Sep 15, 2023

@ccoffrin this is ready to go on my end

Copy link
Member

@tasseff tasseff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, @odow! Super excited by the new nonlinear interface.

@ccoffrin
Copy link
Member

LGTM. Before tagging the next release we should also make sure to fix #156 (which is many be covered in this PR as well)

@tasseff tasseff merged commit 49194c3 into lanl-ansi:master Sep 17, 2023
12 checks passed
@odow odow deleted the od/nlp-expr branch September 17, 2023 21:35
@odow
Copy link
Collaborator Author

odow commented Sep 17, 2023

I just realized one potential issue: do you have projects that integrate PowerModels and WaterModels? If so, if one use the @NL syntax and one uses the new syntax, they're going to error.

@ccoffrin
Copy link
Member

ccoffrin commented Oct 22, 2023

We do have some packages that combine the infrastructure models packages. These are the ones I can think of off the top of my head,
https://github.com/lanl-ansi/PowerModelsITD.jl
https://github.com/lanl-ansi/GasPowerModels.jl
https://github.com/lanl-ansi/PowerWaterModels.jl

As long long as the version of each package that updates to the new NL interface is a breaking release then the package version requirements should prevent incompatible versions. However, I do think we should put a concerted effort into updating the whole ecosystem to the new NL interface, so the packages can still interoperate as they progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HiGHS Dependency Revisit Registered Functions
3 participants