FIX: transformer control dss2eng #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in _bank_transformers! where if a transformer bank has controls, but either has non-sequential phases, e.g., (1, 3) or has phases not starting with 1, e.g., (2,3), then the function would throw an error because the destination conductor index `c` was wrong. Also fixes occasionally failing test Resolves #443
pseudocubic
added
Type: Bug
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
==========================================
+ Coverage 73.53% 73.79% +0.26%
==========================================
Files 72 72
Lines 16301 16300 -1
==========================================
+ Hits 11987 12029 +42
+ Misses 4314 4271 -43
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in _bank_transformers! where if a transformer bank has controls, but either has non-sequential phases, e.g., (1, 3) or has phases not starting with 1, e.g., (2,3), then the function would throw an error because the destination conductor index
cwas wrong.Also fixes occasionally failing test
Resolves #443