Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: p&q vars overwritten in IVRU formulation #439

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

pseudocubic
Copy link
Collaborator

branch p and q variables were being overwritten with transformer and switch variables in the IVRU formulation. This fix ensures that separate pt and qt and psw and qsw variables are created for transformers and switches, respectively.

Closes #437

branch p and q variables were being overwritten with
transformer and switch variables in the IVRU formulation. This fix ensures that separate pt and qt and psw and qsw variables are created for transformers and switches, respectively.

Closes #437
@pseudocubic pseudocubic added Type: Bug Something isn't working Category: Formulations Network Formulation labels Aug 4, 2023
@pseudocubic pseudocubic self-assigned this Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #439 (a4ffcf8) into main (5dac0a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files          72       72           
  Lines       16299    16301    +2     
=======================================
+ Hits        12028    12030    +2     
  Misses       4271     4271           
Files Changed Coverage Δ
src/form/ivr.jl 79.06% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pseudocubic pseudocubic merged commit 3686697 into main Aug 4, 2023
21 checks passed
@pseudocubic pseudocubic deleted the fix-ivru-pq-vars branch August 4, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Formulations Network Formulation Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor typo in var dictionnary for branch power in IVR formulation
1 participant