FIX: bug in _map_eng2math_bus! function #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keatsig
added
Type: Bug
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
=======================================
Coverage 71.75% 71.75%
=======================================
Files 60 60
Lines 15194 15194
=======================================
Hits 10903 10903
Misses 4291 4291
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pseudocubic
approved these changes
Dec 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug in
_map_eng2math_bus!()related to shunts wherebswas calculated using real component of the admittance instead of the imaginary component.