FIX: bug in _dss2eng_loadshape function #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug in _dss2eng_loadshape function that caused pmult to be overwritten with qmult data.
pseudocubic
added
Type: Bug
Codecov Report
@@ Coverage Diff @@
## main #387 +/- ##
==========================================
- Coverage 69.32% 69.32% -0.01%
==========================================
Files 59 59
Lines 14599 14600 +1
==========================================
Hits 10121 10121
- Misses 4478 4479 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
pseudocubic
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug related to
pmultvalues being overwritten byqmultvalues in the_dss2eng_loadshape!(...)function when running multinetwork tests with loadshapes. The option to addpmultandqmultas separate csv files was not working correctly.Closes #386.