-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: OpenDSS PVSystem to PM Generators #105
Conversation
Sorry for the delay. This is an awesome addition! The logging messages of the parser could be updated that some value translation from PVSystem objects to generators actually occurs. A test case with a single-phase PV system may be useful as well. |
@pseudocubic, you've tagged this for Release v0.2.0, are there any breaking changes in here? If not we can put it in v0.1.3. |
@ccoffrin no breaking changes, i only put it in v0.2.0 because we had discussed previously that it was not blocking for tagging v0.1.3 |
Closes #11 |
Adds a warning that PVSystem objects are being converted into TPPM generators. Adds single phase PV test.
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
+ Coverage 76.77% 77.6% +0.82%
=========================================
Files 28 28
Lines 2627 2657 +30
=========================================
+ Hits 2017 2062 +45
+ Misses 610 595 -15
Continue to review full report at Codecov.
|
Adds new feature to changelog
Adds a section to the
dss2tppm_gen!
function to parse PVSystem OpenDSS objects into simple generators as a first approximation. Uses exclusively thekVA
property to determine the generator limitspmin/pmax
andqmin/qmax
, i.e.0/kVA
and-kVA/kVA
, respectively.Added unit test assumes more generation than necessary from PV, and therefore power is expected to be injected back into the sourcebus generator (transmission network).
There are several supported OpenDSS properties for PVSystems that might be more appropriate, and I welcome discussion on the best practice to get the closest approximation to what OpenDSS might be doing.
In particular,
Pmpp
(Power at the max power point, kW @ 1 kW/m2 of irradiation) seems like it might be a better value to determinepmax
. As a first step I was thinking we could assume default values forP-Tcurve
,temperature
, andirradiation
, (i.e. constant, 25C, and 1, respectively), which are all required values to calculate the output power from the PV array. This seems to makePmpp
the hard upper limit on PV generation.Another comment is that in the current implementation of
dss2tppm_pv!
, the OpenDSS properties ofkW
andkvar
are utilized, butkw
is undocumented as an input property (although it is indicated that it is an internal value that can be probed), andkvar
seems to set the PVSystem into a constant kvar mode. Also, I noted that those values are not divided bynconductors
, as we have done in the other generator cases. I therefore have some confusion about the current implementation ofpvsystem
parsing.CC @frederikgeth @ccoffrin
Closes #11