-
Notifications
You must be signed in to change notification settings - Fork 163
Bus merging logic to ensure correct bus type updates #937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Oscar Dowson <odow@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting the name change. I addressed it separately in #959
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #937 +/- ##
=======================================
Coverage 93.71% 93.71%
=======================================
Files 43 43
Lines 9636 9638 +2
=======================================
+ Hits 9030 9032 +2
Misses 606 606
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Proposed fix for #935 and #936.
This update addresses an issue with the bus merging logic to ensure the resulting bus_type is correctly updated when buses are merged.
When two buses are connected by a switch or a zero-impedance line, the merged bus should have the highest priority bus_type (PQ=1, PV=2, Slack=3)
Changes Introduced