Relaxation sine on/off (sign issue)

[harshangrjn]

PowerModels.jl/src/core/relaxation_scheme.jl

Line 120 in 4ee397a

JuMP.@constraint(m, -y + cos(max_ad/2)*(x) <= z*(sin(max_ad/2) + cos(max_ad/2)*max_ad/2) + (1-z)*(cos(max_ad/2)*M_x))

Documenting the issue here. Though the constraint seems valid, the corrected one will be a bit tighter for the OTS formulation. The correct version of this will be a negative sign next to the first cosine term on the RHS, which will also be consistent with

PowerModels.jl/src/core/relaxation_scheme.jl

Line 84 in 4ee397a

JuMP.@constraint(m, y >= cos(max_ad/2)*(x + max_ad/2) - sin(max_ad/2))