-
Notifications
You must be signed in to change notification settings - Fork 21
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: languitar/pass-git-helper
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: languitar/pass-git-helper
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.5.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 7 files changed
- 4 contributors
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 04a0dee - Browse repository at this point
Copy the full SHA 04a0deeView commit details -
Merge pull request #376 from languitar/renovate/black-24.x
chore(deps): update dependency black to v24.4.1
Configuration menu - View commit details
-
Copy full SHA for 0489e36 - Browse repository at this point
Copy the full SHA 0489e36View commit details
Commits on Apr 25, 2024
-
feat: check if password file exists before running
pass
Currently, `pass-git-helper` doesn't check if a password file exists before running `pass`. This leads to authentication failures when the configured password store entry (aka `target`) points to a directory instead of a file. Example: $ tree -F .password-store .password-store/ └── git/ ├── github.com.gpg └── gitlab.com/ ├── user1.gpg └── user2.gpg If target is `git/gitlab.com`, `pass-git-helper` will get the following output from `pass git/gitlab/com`: git/gitlab.com ├── user1 └── user2 and will then use the first line (`git/gitlab/com`) as password. This commit introduces the following changes: 1. To fix the problem described above, `pass-git-helper` first determines the `pass` password store directory as: - the value of `password_store_dir` if defined in `git_pass_mapping.ini` (and non-empty) - the value of the environment variable `PASSWORD_STORE_DIR` if defined (and non-empty) - the default: `~/.password-store` (the latter two correspond to the implementation of `pass`). `pass-git-helper` will then check if an actual `<target>.gpg` is present in the selected directory (to be clear: only one of the three alternative directories gets checked). The new checks implemented in `pass-git-helper` detect two different error cases: 1. the scenario described above where `target` itself is a directory 2. a (rather obscure) scenario where `<target>.gpg` is a directory In both cases, `pass-git-helper` will now exit with an error after presenting the user with a (hopefully) useful error message. 2. The value of `password_store_dir` in the ini file may now contain a leading `~` (*tilde*) which will get replaced by the users *HOME* (or, on Windows, *USERPROFILE*) directory. The change is documented in README.md. 3. New tests for 1. and 2. Fixes #371
Configuration menu - View commit details
-
Copy full SHA for b50ca3b - Browse repository at this point
Copy the full SHA b50ca3bView commit details -
Merge pull request #372 from ktetzlaff/detect-dir-instead-of-or-no-pa…
…ssword-file feat: check if password file exists before running `pass`
Configuration menu - View commit details
-
Copy full SHA for 01252c8 - Browse repository at this point
Copy the full SHA 01252c8View commit details -
chore(release): 1.5.0 [skip ci]
# [1.5.0](v1.4.1...v1.5.0) (2024-04-25) ### Features * check if password file exists before running `pass` ([b50ca3b](b50ca3b)), closes [#371](#371)
Configuration menu - View commit details
-
Copy full SHA for 39fc7c1 - Browse repository at this point
Copy the full SHA 39fc7c1View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.4.1...v1.5.0