[pt] Fix for "ela o ama" in disambiguation.xml rule ID:RARE_POS

[marcoagpinto]

Fix for "Ela o ama" in verbs/nouns rule.

Summary by CodeRabbit

• New Features

  • Enhanced disambiguation rules for Portuguese language processing, including new rules and refined existing ones.
  • Added new examples to clarify rule applications.

• Bug Fixes

  • Improved handling of specific tokens and patterns for better accuracy in language processing.

• Documentation

  • Commented sections indicate areas for future review, aiding in ongoing development efforts.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the disambiguation.xml file for Portuguese language rules in LanguageTool. Key changes include updates to regex patterns for token handling, adjustments to existing rules, the addition of new rules, and commented sections for future review. The overall structure remains intact, while new examples enhance clarity in rule application, reflecting ongoing improvements in the disambiguation process for Portuguese language processing.

Changes

File	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml	- Updated regex patterns for token exceptions in the RARE_POS rule. - Added and modified rules for improved disambiguation. - Commented out sections for future review. - Added new examples for clarity.

Possibly related PRs

• [pt] Improved the disambiguation.xml #10868: Introduces a new rule in disambiguation.xml specifying patterns for verbs and determiners, related to token pattern modifications in the main PR.
• [pt] disambiguation.xml, improved rule ID:RARE_POS #10901: Modifies token patterns in disambiguation.xml, enhancing the RARE_POS rule, aligning with the main PR's changes to broaden matching criteria.
• [pt] Fixed tons of FPs "nouns -> verbs" in disambiguation.xml #10926: Addresses false positives in disambiguation.xml regarding verb/noun distinctions, relevant to the main PR's disambiguation improvements.
• [pt] Fix to disambiguation.xml rule ID:RARE_POS #10977: Updates the RARE_POS rule in disambiguation.xml to include new exceptions, complementing the main PR's handling of specific postags.
• [pt] Major fix in verbs/nouns detection in disambiguation.xml #10991: Adds a new rule in the RARE_POS group and updates existing rules to improve verb/noun detection, directly relating to enhancements in the main PR.

Suggested reviewers

• jaumeortola

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1f46d93 and 5a9e0fa.

📒 Files selected for processing (1)

• languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1 hunks)

🔇 Additional comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (1)

243-243: LGTM! The regex pattern modification correctly addresses the issue.

The addition of [DP].+ to the exception pattern properly handles determiners and pronouns in constructs like "ela o ama", preventing incorrect disambiguation while maintaining the rule's effectiveness for other cases.

Let's verify the impact of this change:

✅ Verification successful

Regex pattern modification is correctly implemented and consistent with other language modules

The verification confirms that:

1. The modified pattern in Portuguese disambiguation.xml is the only instance using [DP].+ exception, making it a targeted fix for the specific issue
2. The RARE_POS rule group is properly defined and maintains consistency with other language modules
3. The verb postag pattern (postag="V.+") is commonly used across multiple language modules, indicating this is a standard approach

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the handling of pronouns in the modified rule
# Test: Check for occurrences of pronoun-based constructs that should be affected
rg -A 2 "ela o ama"

# Test: Verify other similar pronoun patterns that should be handled
ast-grep --pattern $'token postag="V.+" postag_regexp="yes">
  <exception postag_regexp="yes" postag="CS|RG|NC.+|AQ.+|CC|SPS.+|[DP].+"/>'

Length of output: 160

---

Script:

#!/bin/bash
# Let's verify the changes in the disambiguation rules more comprehensively

# Check for similar pronoun-related patterns in disambiguation files
rg -l "postag=\"V.+\"" --type xml

# Look for test cases or examples in Portuguese test files
fd -e xml -e txt . languagetool-language-modules/pt/src/test/ --exec grep -l -i "ela.*ama"

# Check for similar disambiguation rules in the Portuguese module
rg "<token.*postag=\"V.+\".*exception.*\[DP\]" --type xml languagetool-language-modules/pt/

# Look for related documentation or comments
rg -B2 "RARE_POS" languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml

Length of output: 6507

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[marcoagpinto]

"ela o ama" had "ela" appearing as a verb, so I created an exception postag.