Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controller test #9469

Merged
merged 4 commits into from
Oct 18, 2024
Merged

controller test #9469

merged 4 commits into from
Oct 18, 2024

Conversation

s2oBCN
Copy link
Contributor

@s2oBCN s2oBCN commented Oct 17, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

As said in this request #9468 this is an example of IT.
I had to improve the Factory Pattern of the APP splitting the code in 2 classes one the factory and the other the app entry point (as described here here https://medium.com/@ferrohardian/application-factory-pattern-starting-your-flask-project-e17dd2f12013). Without this improviment the test executes two times the create_app method.

Fixes #9468

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • End to end test: execute the hole system to verify that the split of the app.py doesn't break anything
  • Integration test: execute the integration test created with debug from vscode and see that the app stops in the breaking point in the controller and returns 200.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request labels Oct 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 18, 2024
@crazywoola crazywoola merged commit 28de676 into langgenius:main Oct 18, 2024
6 checks passed
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Controller testing
2 participants