Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Optimize operations in Q&A mode #9274

Merged
merged 2 commits into from
Oct 14, 2024
Merged

chore: Optimize operations in Q&A mode #9274

merged 2 commits into from
Oct 14, 2024

Conversation

Blubiubiu
Copy link
Contributor

@Blubiubiu Blubiubiu commented Oct 12, 2024 •
edited
Loading

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Optimizations:
1，In Q&A mode, disable language switching during segmentation.
Prevent the language from being changed while the system is performing segmentation.

image

2，In Q&A mode, trigger re-segmentation after segmentation is complete if the language is switched.
After segmentation is completed, if the user switches the language, trigger a new segmentation process.
image

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. labels Oct 12, 2024
@Blubiubiu Blubiubiu changed the title chore: add disabled for popover chore: Optimize operations in Q&A mode Oct 12, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2024
@crazywoola crazywoola merged commit 5ee7e03 into langgenius:main Oct 14, 2024
4 checks passed
Scorpion1221 added a commit to yybht155/dify that referenced this pull request Oct 21, 2024
@Scorpion1221
Merge commit '5c7b1358d49c8df54bc39eea7b9c4d9b41c09fcb'
b0086df 
* commit '5c7b1358d49c8df54bc39eea7b9c4d9b41c09fcb': (235 commits)
  chore(release): bump version to 0.9.2 (langgenius#9314)
  fix: token refreshing logic issue (langgenius#9308)
  fix: Add new Milvus Lite wheel for manylinux2014_aarch64 (langgenius#9316)
  chore: add reopen preview btn (langgenius#9279)
  chore: Optimize operations in Q&A mode (langgenius#9274)
  refactor: Refactor the service of retrieval the recommend app (langgenius#9302)
  chore: remove the copied zhipu_ai sdk (langgenius#9270)
  fix: remove the latest message from the user that does not have any answer yet (langgenius#9297)
  Add Volcengine VikingDB as new vector provider (langgenius#9287)
  chore: translate i18n files (langgenius#9288)
  chore: add baidu-obs and supabase for .env.example (langgenius#9289)
  chore: add abstract decorator and output log when query embedding fails (langgenius#9264)
  Feat/new account page (langgenius#9236)
  Feat/implement-refresh-tokens (langgenius#9233)
  feat: refresh-token (langgenius#9286)
  chore: translate i18n files (langgenius#9284)
  feat:support baidu vector db (langgenius#9185)
  Feat: rerank model verification in front end (langgenius#9271)
  Fix/s3 iam add region name (langgenius#7819)
  chore: optimize the trace ops slow queries on node executions. (langgenius#9282)
  ...

# Conflicts:
#	web/package.json
#	web/yarn.lock
lau-td pushed a commit to heydevs-io/dify that referenced this pull request Oct 23, 2024
@Blubiubiu @lau-td
chore: Optimize operations in Q&A mode (langgenius#9274)
14b7931 
Co-authored-by: billsyli <billsyli@tencent.com>
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
@Blubiubiu @JunXu01
chore: Optimize operations in Q&A mode (langgenius#9274)
e5febf4 
Co-authored-by: billsyli <billsyli@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Blubiubiu @crazywoola